Create store view using the command line #29408

0m3r · 2020-08-05T13:31:39Z

Description (*)

Create a new store view using the command line

Usage

➜  magento.local git:(master) ✗  bin/magento store:create -h 
Description:
  Create new store view (see list: bin/magento store:list)

Usage:
  store:create [options] [--] <name> <code> [<is_active> [<sort_order>]]

Arguments:
  name                       Put the store view name you want to create 
  code                        Put the code 
  is_active                  Status (enable/disable) [default: true]
  sort_order                Sort Order [default: 0]

Options:
  -g, --group_id[=GROUP_ID]  Group ID (php bin/magento store:list). [default: "1"]
  -h, --help                 Display this help message
  -q, --quiet                Do not output any message
  -V, --version              Display this application version
      --ansi                 Force ANSI output
      --no-ansi              Disable ANSI output
  -n, --no-interaction       Do not ask any interactive question
  -v|vv|vvv, --verbose       Increase the verbosity of messages: 1 for normal output, 2 for more verbose output and 3 for debug

➜  magento.local git:(master) ✗ bin/magento store:create "Deutschland" de 1 20 -g 1

Fixed Issues (if relevant)

Fixes Create New CLI command: create store view community-features#288

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-08-05T13:31:42Z

Hi @0m3r. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

swnsma · 2020-08-07T15:14:07Z

Hi @0m3r!
Thank you for your contribution!
Before we start with code review, could you create a ticket in https://github.com/magento/community-features/

Adding of new feature need to be agreed with Magento Team first, so it could provide some delay in review.

0m3r · 2020-08-10T07:16:24Z

Hi @0m3r!
Thank you for your contribution!
Before we start with code review, could you create a ticket in https://github.com/magento/community-features/

Adding of new feature need to be agreed with Magento Team first, so it could provide some delay in review.

magento/community-features#288

VladimirZaets · 2020-08-11T13:24:39Z

Hi @0m3r, thanks for collaboration. Because it's new functionality it should be discussed with our PO first, due to it I move this PR to on-hold column

ihor-sviziev · 2020-10-05T12:04:47Z

@VladimirZaets @sidolov @gabrieldagama is there any updates on it? 2.5 months are passed

sivaschenko · 2020-10-06T11:42:41Z

@ihor-sviziev @0m3r sorry for the delay, working with Product team to approve the new cool feature and set the priority for the pull request

sivaschenko · 2020-10-06T11:44:56Z

@magento run Magento Health Index, Semantic Version Checker

sivaschenko · 2020-10-06T13:36:22Z

The delivery of the new command confirmed with @nrkapoor

sivaschenko

@0m3r thanks for the pull request! Can you please extract the business logic of store creation to a model and cover the functionality with integration tests

sivaschenko · 2020-11-02T17:47:59Z

@0m3r the examples of integration tests can be found in dev/tests/integration directory.

Basically the integration test for GetDefaultStoreGroup should:

Use a fixture to create storegorups/websites/etc
Call GetDefaultStoreGroup::execute and verify the return value
Rollback fixture will take care of the system cleanup

The integration test for CreateStore should:

Call CreateStore::execute method passing the data from data provider (to enable variations)
Load the create store to verify it's actually created
Delete the created store

Integration tests have been proven to be more reliable as they are running the actual code without mocks and less fragile as they are not tied to the internal class implementation details like the sequence of calls, etc.

engcom-Charlie · 2020-11-12T13:59:48Z

@0m3r could you please cover your changes by integration tests as mentioned #29408 (comment)?
Thank you.

0m3r · 2020-11-12T14:17:45Z

@0m3r could you please cover your changes by integration tests as mentioned #29408 (comment)?
Thank you.

Sorry, I do not have time right now. too many other work

…agento2 into feature-create-store-view-command

0m3r · 2020-12-01T13:50:31Z

I found some error while integration tests running and fix it.
ed4a1fe

0m3r · 2020-12-02T09:15:30Z

@sivaschenko please review my integration tests

phpunit.xml

         <testsuite name="CreateStoreSuit">
            <file>testsuite/Magento/Store/Model/CreateStoreTest.php</file>
            <file>testsuite/Magento/Store/Model/GetDefaultStoreGroupTest.php</file>
        </testsuite>

bin/magento dev:tests:run integration -c'--testsuite=CreateStoreSuit'

sivaschenko

@0m3r thanks for the integration test coverage! Please see my review comments.

Also, I'd like to notify you that this pull request was prioritized as P3 that will affect the processing time (We will be able to process it only after P1, P2 PRs)

dev/tests/integration/testsuite/Magento/Store/Model/GetDefaultStoreGroupTest.php

dev/tests/integration/testsuite/Magento/Store/Model/CreateStoreTest.php

dev/tests/integration/testsuite/Magento/Store/Model/GetDefaultStoreGroupTest.php

dev/tests/integration/testsuite/Magento/Store/Model/CreateStoreTest.php

app/code/Magento/Store/Model/CreateStore.php

dev/tests/integration/testsuite/Magento/Store/Model/CreateStoreTest.php

sivaschenko

Thanks for the updates @0m3r !

app/code/Magento/Store/Model/CreateStore.php

0m3r added 2 commits August 5, 2020 16:04

Added cli command to create store view

322cb25

Sterilized name and code arguments

10352e9

ghost added the Progress: pending review label Aug 5, 2020

magento-engcom-team added Component: Store Release Line: 2.4 labels Aug 5, 2020

swnsma self-requested a review August 7, 2020 15:09

swnsma self-assigned this Aug 7, 2020

0m3r mentioned this pull request Aug 10, 2020

Create New CLI command: create store view magento/community-features#288

Open

ghost added Progress: to approve and removed Progress: pending review labels Aug 11, 2020

VladimirZaets added the Progress: on hold label Aug 11, 2020

ghost removed the Progress: to approve label Aug 11, 2020

VladimirZaets and others added 2 commits August 11, 2020 08:24

Merge branch '2.4-develop' into feature-create-store-view-command

1e21918

Merge branch '2.4-develop' into feature-create-store-view-command

7949e0c

ghost added Progress: review and removed Progress: on hold labels Oct 6, 2020

sivaschenko self-assigned this Oct 6, 2020

sivaschenko added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Oct 6, 2020

sivaschenko requested changes Oct 6, 2020

View reviewed changes

ghost added Progress: needs update and removed Progress: review labels Oct 6, 2020

Merge branch '2.4-develop' into feature-create-store-view-command

5d14696

0m3r added 2 commits December 1, 2020 15:45

Prevent integration test failing (Table store_website doesn\'t exist)

ed4a1fe

Merge branch 'feature-create-store-view-command' of github.com:0m3r/m…

fab0237

…agento2 into feature-create-store-view-command

0m3r added 2 commits December 1, 2020 17:56

Add integration test for CreateStore

d2e1f40

Add GetDefaultStoreGroupTest

5e8ec78

sivaschenko requested changes Jan 5, 2021

View reviewed changes

Applied some of @sivaschenko's suggestions

024fe1d

m2-community-project bot added Progress: review and removed Progress: needs update labels Jan 6, 2021

0m3r requested a review from sivaschenko January 6, 2021 08:56

sivaschenko reviewed Jan 6, 2021

View reviewed changes

app/code/Magento/Store/Model/CreateStore.php Outdated Show resolved Hide resolved

0m3r added 2 commits January 8, 2021 11:40

CreateStore::execute accept a StoreInterface instead of array

0d528ea

Fixed PHPdoc param name typo

5e87d6e

0m3r requested a review from sivaschenko January 8, 2021 09:45

sivaschenko removed their assignment Apr 15, 2021

sivaschenko removed their request for review April 15, 2021 12:46

0m3r added 9 commits June 23, 2021 15:39

Merge branch '2.4-develop' into feature-create-store-view-command

1a8e31c

Merge branch '2.4-develop' into feature-create-store-view-command

4c5188f

Merge branch '2.4-develop' into feature-create-store-view-command

b333b5b

Merge branch '2.4-develop' into feature-create-store-view-command

37f731d

Merge branch '2.4-develop' into feature-create-store-view-command

ff6ca5f

Merge branch '2.4-develop' into feature-create-store-view-command

25e08f3

Merge branch '2.4-develop' into feature-create-store-view-command

9b39023

Merge branch '2.4-develop' into feature-create-store-view-command

341a347

Merge branch '2.4-develop' into feature-create-store-view-command

f70a5d0

Create store view using the command line #29408

Are you sure you want to change the base?

Create store view using the command line #29408

Uh oh!

Conversation

0m3r commented Aug 5, 2020 • edited by sivaschenko Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Fixed Issues (if relevant)

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Aug 5, 2020

Uh oh!

swnsma commented Aug 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0m3r commented Aug 10, 2020

Uh oh!

VladimirZaets commented Aug 11, 2020

Uh oh!

ihor-sviziev commented Oct 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sivaschenko commented Oct 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sivaschenko commented Oct 6, 2020

Uh oh!

sivaschenko commented Oct 6, 2020

Uh oh!

sivaschenko left a comment

Choose a reason for hiding this comment

Uh oh!

sivaschenko commented Nov 2, 2020

Uh oh!

engcom-Charlie commented Nov 12, 2020

Uh oh!

0m3r commented Nov 12, 2020

Uh oh!

0m3r commented Dec 1, 2020

Uh oh!

0m3r commented Dec 2, 2020

Uh oh!

sivaschenko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sivaschenko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

0m3r commented Aug 5, 2020 •

edited by sivaschenko

Loading

swnsma commented Aug 7, 2020 •

edited

Loading

ihor-sviziev commented Oct 5, 2020 •

edited

Loading

sivaschenko commented Oct 6, 2020 •

edited

Loading